Enhancement of tick label offset text positioning #5243
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly for the xaxis on top or bottom.
|
Need to fix up the failing test and look at a possible test for xaxis. Will do that tomorrow |
|
👍 |
|
probably should add something to |
tacaswell
modified the milestones:
2.1 (next point release),
2.2 (next next feature release)
|
This is still a bug in master. @cimarronm any chance you have time to rebase and resurect this? |
|
This appears to be done by #15592. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables missing functionality to properly locate the offset text for the xaxis when either located at the top or bottom of the plot.
It uses an unused attribute
offset_text_positionthat looks like it was incorporated with this in mind but the functionality never was added.