Do not rely on outer scope variables in `ImageComparisonTest.test.do_… #7425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test` `do_test` function variables are changed by loop where function was creates. It will work as you expect only if you call yielded function immediately.
QuLogic
approved these changes
Nov 8, 2016
QuLogic
changed the title
dopplershift
approved these changes
Nov 8, 2016
dopplershift
changed the title
QuLogic
modified the milestones:
2.0.1 (next bug fix release),
2.0 (style change major release)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…test`
do_testfunction variables are changed by loop where function was created.It will work as you expect only if you call yielded function immediately.
At suggestion of @QuLogic