Skip to content

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 15, 2017

Alternative to #7825, see #7816 for original issue.

@codecov-io
Copy link

codecov-io commented Jan 15, 2017

Current coverage is 62.23% (diff: 100%)

Merging #7833 into master will increase coverage by 0.13%

@@             master      #7833   diff @@
==========================================
  Files           174        174          
  Lines         56052      56287   +235   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          34809      35031   +222   
- Misses        21243      21256    +13   
  Partials          0          0          

Powered by Codecov. Last update b078a19...cce8539

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jan 15, 2017
@tacaswell tacaswell changed the title Deprecate unused verification code. [MRG+1] Deprecate unused verification code. Jan 15, 2017
@NelleV
Copy link
Member

NelleV commented Jan 15, 2017

@anntzer I am having a hard time tracking which PR supersedes which one.
Is it possible to close the old straight away? You can still link to them, but it avoids opened PR that have a proposed patch for something that has been merged.

@NelleV NelleV merged commit 6f61b26 into matplotlib:master Jan 15, 2017
@NelleV
Copy link
Member

NelleV commented Jan 15, 2017

I think it is a good time to also mentioned that we are starting a project at BIDS that should help us identify duplicated PR, and opened tickets mentioned in PR that have been merged.

@anntzer anntzer deleted the deprecate-xmllint-verification branch January 15, 2017 19:05
@anntzer
Copy link
Contributor Author

anntzer commented Jan 15, 2017

You got it right.

@QuLogic QuLogic changed the title [MRG+1] Deprecate unused verification code. Deprecate unused verification code. Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants