Fix description and remove unused code from scatter example #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
story645
reviewed
Nov 23, 2022
| ================================================== | ||
| An simple scatter plot using PathCollectionWrapper |
Member
There was a problem hiding this comment.
A, and do cross-references work here? (Also if it's still a lassajous, why not say that?)
Member
Author
There was a problem hiding this comment.
This is not lissajous, I just was having a transform problem originally, so I copied that example and simplified it in a couple steps and then decided it was worth keeping as an example that didn't have animations, etc. Just didn't change the title/description.
I will try to properly cross reference
Member
Author
There was a problem hiding this comment.
My understanding is that is standard practice to not use cross references in titles, so I will add a sentence underneath with the cross references
story645
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.