Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add basic function to get all data for a user out of synapse #5589
This is currently not hooked up to anything. The plan is to write a command app type thing that lets you run such functionality manually without having to hit production instances.
Note: This only fetches events that a user can see, rather than all data we store for a user.
(This is a port of a hacky script we manually run to do this currently)
@@ Coverage Diff @@ ## develop #5589 +/- ## =========================================== + Coverage 63.2% 63.26% +0.05% =========================================== Files 328 328 Lines 35931 35995 +64 Branches 5918 5932 +14 =========================================== + Hits 22710 22772 +62 - Misses 11595 11598 +3 + Partials 1626 1625 -1
richvdh left a comment
A lot of quibbling about comments and names, but generally looks sane to me.
I'm raising a bit of an eyebrow at the mix of synchronous I/O with asynchronous database ops. I guess it's fine as long as the functions in question are only called from an external process, but it may be worth adding a health-warning to the functions? Better, could they even be moved to a separate python module?