Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repeated calls to config.stats_enabled. #6255

Merged
merged 3 commits into from Oct 25, 2019

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Oct 25, 2019

Turns out that fetching variables from the config object is expensive,
so doing it once at startup avoids unnecessary work.

Turns out that fetching variables from the config object is expensive,
so doing it once at startup avoids unnecessary work.
@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Oct 25, 2019
Copy link
Member

richvdh left a comment

lgtm

@erikjohnston erikjohnston merged commit 87259b3 into release-v1.5.0 Oct 25, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #5126 passed (19 minutes, 25 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 27 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 34 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/mypy Passed (47 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (18 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 36 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 24 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 16 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 13 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (16 minutes, 44 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 35 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 33 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (14 minutes, 37 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (11 minutes, 54 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (13 minutes, 32 seconds)
Details
richvdh added a commit that referenced this pull request Oct 28, 2019
Synapse 1.5.0rc2 (2019-10-28)
=============================

Bugfixes
--------

- Update list of boolean columns in `synapse_port_db`. ([\#6247](#6247))
- Fix /keys/query API on workers. ([\#6256](#6256))
- Improve signature checking on some federation APIs. ([\#6262](#6262))

Internal Changes
----------------

- Move schema delta files to the correct data store. ([\#6248](#6248))
- Small performance improvement by removing repeated config lookups in room stats calculation. ([\#6255](#6255))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.