Skip to content

Adding explain check #22797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2025
Merged

Adding explain check #22797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b3f802
Adding explain check
fengttt Nov 7, 2025
6f27d26
Merge branch 'main' into fengttt-explain-check
fengttt Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions pkg/frontend/mysql_cmd_executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1888,23 +1888,23 @@ func getExplainOption(reqCtx context.Context, options []tree.OptionElem) (*expla
return es, nil
} else {
for _, v := range options {
if strings.EqualFold(v.Name, "VERBOSE") {
if strings.EqualFold(v.Name, tree.VerboseOption) {
if strings.EqualFold(v.Value, "TRUE") || v.Value == "NULL" {
es.Verbose = true
} else if strings.EqualFold(v.Value, "FALSE") {
es.Verbose = false
} else {
return nil, moerr.NewInvalidInputf(reqCtx, "invalid explain option '%s', valud '%s'", v.Name, v.Value)
}
} else if strings.EqualFold(v.Name, "ANALYZE") {
} else if strings.EqualFold(v.Name, tree.AnalyzeOption) {
if strings.EqualFold(v.Value, "TRUE") || v.Value == "NULL" {
es.Analyze = true
} else if strings.EqualFold(v.Value, "FALSE") {
es.Analyze = false
} else {
return nil, moerr.NewInvalidInputf(reqCtx, "invalid explain option '%s', valud '%s'", v.Name, v.Value)
}
} else if strings.EqualFold(v.Name, "FORMAT") {
} else if strings.EqualFold(v.Name, tree.FormatOption) {
if strings.EqualFold(v.Value, "TEXT") {
es.Format = explain.EXPLAIN_FORMAT_TEXT
} else if strings.EqualFold(v.Value, "JSON") {
Expand All @@ -1914,6 +1914,10 @@ func getExplainOption(reqCtx context.Context, options []tree.OptionElem) (*expla
} else {
return nil, moerr.NewInvalidInputf(reqCtx, "invalid explain option '%s', valud '%s'", v.Name, v.Value)
}
} else if strings.EqualFold(v.Name, tree.CheckOption) {
if err := json.Unmarshal([]byte(v.Value), &es.CheckExpr); err != nil {
return nil, moerr.NewInvalidInputf(reqCtx, "invalid explain option '%s', valud '%s': %s", v.Name, v.Value, err.Error())
}
} else {
return nil, moerr.NewInvalidInputf(reqCtx, "invalid explain option '%s', valud '%s'", v.Name, v.Value)
}
Expand Down
Loading
Loading