Conversation
hmhealey
added
2: Dev Review
Contributor
|
I've done a cursory review of the general architecture of this, and it looks good to me. Will try and take a more detailed look at it later. |
jwilander
requested changes
May 15, 2017
Member
jwilander
left a comment
jwilander
left a comment
There was a problem hiding this comment.
Looks good, just some minor comments
api4/context.go
Outdated
| return c | ||
| } | ||
|
|
||
| l4g.Error("job_id=" + c.Params.JobId) |
Member
There was a problem hiding this comment.
Debug statement you forgot to remove?
api4/context.go
Outdated
| return c | ||
| } | ||
|
|
||
| l4g.Error("job_type=" + c.Params.JobType) |
api4/job.go
Outdated
| ) | ||
|
|
||
| func InitJob() { | ||
| l4g.Error("Initializing post API routes") |
Member
There was a problem hiding this comment.
Shouldn't this be Info and copy/paste error saying post
coreyhulen
approved these changes
May 17, 2017
jwilander
approved these changes
May 17, 2017
grundleborg
approved these changes
May 17, 2017
grundleborg
added
4: Reviews Complete
esethna
added
Docs/Not Needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the framework for the job server that will be able to either run jobs (data retention, search indexing, etc) as either part of the main Mattermost server or from a standalone executable. I had to make some changes to the enterprise imports for this:
einterfaces/jobspackage to avoid an import cycle ofeinterfaces > store > einterfacesAnd a few things to note about the job server itself:
make build-job-serverand ran withmake run-job-serverjobspackage and is ran by both the platform and standalone job server located in thejobs/jobserverpackage.jobspackage should only rely on themodel,utils, andstorepackages however it could probably also useappcode should we need it.Ticket Link
https://mattermost.atlassian.net/browse/PLT-6408
Checklist