Move patch-package to be a non-dev dependency #6
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that it's actually downloaded when this package is installed as a dependency of other code. I chose that instead of making it a required peer dependency because, while this is a bit janky, I feel like it makes the library easier to use by MM plugins. In the long term, we should look at replacing the patched packages or properly forking them because this is sure to cause problems at some point because having this package mess with other packages in the node_modules is a terrible idea. Or we could look at actually publishing this properly, or we could just remove React Bootstrap from MM finally. Regardless, this is a hacky fix to keep a hacky fix working.
This was referenced Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This ensures that it's actually downloaded when this package is installed as a dependency of other code. I chose that instead of making it a required peer dependency because, while this is a bit janky, I feel like it makes the library easier to use by MM plugins.
In the long term, we should look at replacing the patched packages or properly forking them because this is sure to cause problems at some point because having this package mess with other packages in the node_modules is a terrible idea. Or we could look at actually publishing this properly, or we could just remove React Bootstrap from MM finally. Regardless, this is a hacky fix to keep a hacky fix working.