Skip to content

Conversation

tuxlinuxien
Copy link
Contributor

Upsert has been added to SQLite3 v3.24.0.

Since this feature has been wanted for quite a longtime, I hope we can see it soon and prod ready for go-sqlite3.

Best regards.

@coveralls
Copy link

coveralls commented Jun 7, 2018

Coverage Status

Coverage decreased (-5.8%) to 55.366% when pulling 4747026 on tuxlinuxien:master into 6d0b39d on mattn:master.

@gjrtimmer
Copy link
Collaborator

Quick question: Did you do an manual update or did you used the provided upgrade tool?

@tuxlinuxien
Copy link
Contributor Author

tuxlinuxien commented Jun 7, 2018

I did the upgrade manually and run the test to make sure it was compatible. I have found out the upgrade tool just after my pull request.
I have seen the upgrade tool does some changes, but since the manual update still work, I was thinking it was not important.

But you are right, let me use the upgrade tool and push again and sorry if I have messed up.

@tuxlinuxien
Copy link
Contributor Author

@gjrtimmer I see my error when I don't use the upgrade tool, it had messed up with the includes. my latest commit fix that.

Thank for your tip.

@tuxlinuxien tuxlinuxien closed this Jun 9, 2018
@gjrtimmer
Copy link
Collaborator

@tuxlinuxien The new upgrade tool merges the User Authentication Module into the main binding, currently requried because this has been included within the master.

@tuxlinuxien
Copy link
Contributor Author

@gjrtimmer I have closed this PR and created a new one ( #589 ). I have used the upgrade tool and fixed the TestUpsert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants