bump sqlite3 3.24.0 and add TestUpsert. #589
Conversation
|
@tuxlinuxien will try and test it today. Any other new features we should be looking into ? |
|
@gjrtimmer the only thing I am aware of is the UPSERT feature. However is page is still marked as draft so maybe more official features will be announced later. |
|
@tuxlinuxien Because this in an update of sqlite we probably also should look into the new Auxiliary columns. Do you think we need to update the virtual table and testing to support this out-of-the-box ? |
@gjrtimmer to be honest my knowledge are limited about the core of sqlite3 so I am not the right person to answer this question. Sorry |
sqlite3_test.go
Outdated
| func TestUpsert(t *testing.T) { | ||
| _, n, _ := Version() | ||
| if !(n >= 3024000) { | ||
| t.Log("Your version of sqlite3 doesn't support UPSERT feature.") |
There was a problem hiding this comment.
Can you replace line 237-240 (including the return) with.
t.Skip("UPSERT requires sqlite3 => 3.24.0")Reason: Output of the test results.
|
@tuxlinuxien Not a problem, I think UPSERT is the most important one, which people are waiting for. I've requested one change to your code, which is solid and very nice. Change I've requested is to limit the output lines of the test when its skipped. |
|
@gjrtimmer done. Just need to wait for travis to check this up. $>go test --tags='libsqlite3' -v ./. # local libsqlite3 3.22.0
[...]
=== RUN TestUpsert
--- SKIP: TestUpsert (0.00s)
sqlite3_test.go:237: UPSERT requires sqlite3 => 3.24.0
[...] |
|
@tuxlinuxien Will merge after Travis-CI |
3 participants
No description provided.