[bugfix]正規表現修正 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before:
We couldn't post without version-added tag
After:
We can post with tags!!
Owner
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
前回の「タグ対応」のコードレビューにて、
\s\+と書かれていたところを\s+と書いてしまっており、+が正規表現として機能してくれていませんでした...その弊害として、現状だと「先頭がバージョン情報がないタグ」だと投稿ができず、またバージョン情報があるタグだとしても「それ以降のタグは無視されてしまう」状況です。
連投してしまっており申し訳ないです...orz