Skip to content

Conversation

@matbcvo
Copy link
Contributor

@matbcvo matbcvo commented Sep 11, 2025

Description

The version switcher in the sidebar had white text on a white background, making options invisible until hovered.

This PR sets the <option> text color to #404040 for better readability.

Screenshots or screen recordings

Before

image

After

image

@matbcvo matbcvo requested a review from a team as a code owner September 11, 2025 22:46
@matbcvo matbcvo requested review from RCheesley, adiati98 and favour-chibueze and removed request for a team September 11, 2025 22:46
Copy link
Contributor

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the important accessibility improvement here, @matbcvo! ✨

Just want to confirm. In the screenshot, the hover state background is light blue. But when I checked, it's blue as the screenshot below. It really is blue, right? (I want to confirm my eyes 😂)

Dropdown menu with black font color and white background

@matbcvo
Copy link
Contributor Author

matbcvo commented Sep 16, 2025

Thanks for the important accessibility improvement here, @matbcvo! ✨

Just want to confirm. In the screenshot, the hover state background is light blue. But when I checked, it's blue as the screenshot below. It really is blue, right? (I want to confirm my eyes 😂)

The hover background color changes to light blue when I open the browser's developer tools, but it is actually blue, as shown in your screenshot.

@adiati98
Copy link
Contributor

The hover background color changes to light blue when I open the browser's developer tools, but it is actually blue, as shown in your screenshot.

Awesome! Thanks for the confirmation.

@adiati98
Copy link
Contributor

@matbcvo I have another question. I can't find the dropdown when I tested this locally as the screenshot below.

Screenshot 2025-09-16 210129

So, I have to depend solely to this check live preview.

I'm not sure if it's because this update is based on branch 7.0 or something else going on. But after I clicked a version in the dropdown, the font color is get back to white. Please see the screen recording below.

Screen.Recording.2025-09-16.211737.mp4

@matbcvo
Copy link
Contributor Author

matbcvo commented Sep 16, 2025

When testing locally, you will only see one branch, so no dropdown appears. In the live preview, this works only on 7.0, since this PR targets that branch. It needs to be backported to other branches (6.0, 5.2, 4.x etc).

adiati98
adiati98 previously approved these changes Sep 16, 2025
Copy link
Contributor

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this important fix, @matbcvo ! 🚀

Can you also backport this to other branches? Many thanks in advance! ✨️

@matbcvo
Copy link
Contributor Author

matbcvo commented Sep 16, 2025

#434 for 6.0
#435 for 5.2
#436 for 4.x

@adiati98 adiati98 dismissed their stale review September 17, 2025 05:45

I've merged 5.2, but there is an error when clicking other docs versions. We need to confirm and fix this first before going forward.

@adiati98
Copy link
Contributor

adiati98 commented Sep 17, 2025

Hey @matbcvo,

I've merged in #435. But the dropdown behavior is the same as what I mentioned in this comment.

So, I dismissed my reviews in other PRs for now until I can get confirmation before moving forward as the merge from 5.2 this is now live and public and it causes these problems:

  • When we click and go from 5.2 to other version in the docs, the text changes back to white.
  • 5.2 is gone.
  • Once we reach 4.0, the dropdown doesn't work. We need to change the URL to go back to 5.2.

Is this the behaviour that you mentioned? Since 5.2 is the target branch?
If not, we need to fix this first or revert to the previous condition before the merge. Please see the screen recording below:

dropdown-error.mp4

@matbcvo
Copy link
Contributor Author

matbcvo commented Sep 17, 2025

When we click and go from 5.2 to other version in the docs, the text changes back to white.

This is expected, since this and the other backport PRs are not yet merged - they all need to be merged.

  • 5.2 is gone.
  • Once we reach 4.0, the dropdown doesn't work. We need to change the URL to go back to 5.2.

This doesn't seem to be related to this PR. We can try reverting PR #435 to check if the problem still exists. If it does, then we know that it's unrelated to this PR and we can proceed with merging the PRs. It looks like a Read the Docs project configuration that Ruth needs to check (eg which versions each branch should display).

@adiati98
Copy link
Contributor

adiati98 commented Sep 17, 2025

This doesn't seem to be related to this PR. We can try reverting PR #435 to check if the problem still exists. If it does, then we know that it's unrelated to this PR and we can proceed with merging the PRs. It looks like a Read the Docs project configuration that Ruth needs to check (eg which versions each branch should display).

Noob question. How can I revert a merged PR? 😁

Each branch should display each version in the docs. If you ever need me to check configuration on Read the Docs, I have access to it. Just let me know where or what to look at. (I'm new with Sphinx and Read the Docs).

Thanks so much for all your prompt replies! I learned so much from you. 🙂

@matbcvo
Copy link
Contributor Author

matbcvo commented Sep 17, 2025

Noob question. How can I revert a merged PR? 😁

There's a "Revert" button shown where the PR was merged (see the image below). I've created a revert PR for now. #438

image

@adiati98
Copy link
Contributor

There's a "Revert" button shown where the PR was merged (see the image below). I've created a revert PR for now. #438

I've merged the revert PR just now. Let me check this in a moment.

@adiati98
Copy link
Contributor

I can confirm that the behaviour persists, like before the merge. I suspect it might be caused from branch 4.x because both prose and build checks are failed in this branch. Read the Docs also shows that Sphinx version in 4.x is outdated. You can see my new issue here.

I think we can proceed further, then.
Do you need to create a new PR for branch 5.2?

@matbcvo
Copy link
Contributor Author

matbcvo commented Sep 17, 2025

Opened a new PR for 5.2: #439

Copy link
Contributor

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@adiati98 adiati98 merged commit 01cd13f into mautic:7.0 Sep 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants