-
Notifications
You must be signed in to change notification settings - Fork 62
Fix invisible text in sidebar version dropdown options #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
adiati98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the important accessibility improvement here, @matbcvo! ✨
Just want to confirm. In the screenshot, the hover state background is light blue. But when I checked, it's blue as the screenshot below. It really is blue, right? (I want to confirm my eyes 😂)
The hover background color changes to light blue when I open the browser's developer tools, but it is actually blue, as shown in your screenshot. |
Awesome! Thanks for the confirmation. |
|
@matbcvo I have another question. I can't find the dropdown when I tested this locally as the screenshot below.
So, I have to depend solely to this check live preview. I'm not sure if it's because this update is based on branch Screen.Recording.2025-09-16.211737.mp4 |
|
When testing locally, you will only see one branch, so no dropdown appears. In the live preview, this works only on 7.0, since this PR targets that branch. It needs to be backported to other branches (6.0, 5.2, 4.x etc). |
adiati98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this important fix, @matbcvo ! 🚀
Can you also backport this to other branches? Many thanks in advance! ✨️
I've merged 5.2, but there is an error when clicking other docs versions. We need to confirm and fix this first before going forward.
|
Hey @matbcvo, I've merged in #435. But the dropdown behavior is the same as what I mentioned in this comment. So, I dismissed my reviews in other PRs for now until I can get confirmation before moving forward as the merge from
Is this the behaviour that you mentioned? Since 5.2 is the target branch? dropdown-error.mp4 |
This is expected, since this and the other backport PRs are not yet merged - they all need to be merged.
This doesn't seem to be related to this PR. We can try reverting PR #435 to check if the problem still exists. If it does, then we know that it's unrelated to this PR and we can proceed with merging the PRs. It looks like a Read the Docs project configuration that Ruth needs to check (eg which versions each branch should display). |
Noob question. How can I revert a merged PR? 😁 Each branch should display each version in the docs. If you ever need me to check configuration on Read the Docs, I have access to it. Just let me know where or what to look at. (I'm new with Sphinx and Read the Docs). Thanks so much for all your prompt replies! I learned so much from you. 🙂 |
There's a "Revert" button shown where the PR was merged (see the image below). I've created a revert PR for now. #438
|
I've merged the revert PR just now. Let me check this in a moment. |
|
I can confirm that the behaviour persists, like before the merge. I suspect it might be caused from branch I think we can proceed further, then. |
|
Opened a new PR for 5.2: #439 |
adiati98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀


Description
The version switcher in the sidebar had white text on a white background, making options invisible until hovered.
This PR sets the
<option>text color to #404040 for better readability.Screenshots or screen recordings
Before
After