Skip to content

Conversation

@beneyalraj
Copy link
Contributor

Description

I have made 1 commit

  • I have replaced the docs/configuration/shortener-bitly.png image with 5.2 version image
  • Replaced image is in PNG format
  • I have tested it locally, renders fine
  • I have reviewed the .rst file, no change is needed as replaced image filename matches perfectly

Linked issue

Closes #392

Screenshots or screen recordings

BEFORE CHANGE:

Screenshot 2025-10-06 at 3 48 37 PM

AFTER CHANGE:

Screenshot 2025-10-06 at 3 49 21 PM

…file no change need as name matches perfectly
@beneyalraj beneyalraj requested a review from a team as a code owner October 6, 2025 10:34
@beneyalraj beneyalraj requested review from adiati98 and favour-chibueze and removed request for a team October 6, 2025 10:34
@beneyalraj
Copy link
Contributor Author

@adiati98

i got confused by the time conversion. its monday night in the country where i live, ill keep this in mind
Should i close this PR and raise a new one? or the existing PR is fine?

@adiati98
Copy link
Contributor

adiati98 commented Oct 6, 2025

You don't need to close this PR. We'll review it within this week. 👍

@beneyalraj
Copy link
Contributor Author

Sure @adiati98

Can you assign me some 5.2 version issues, I comment on? I'll work on it within 2 days and raise a PR which you can review on your free time

Let me know if that is possible

Copy link
Contributor

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beneyalraj Thanks for the PR! ✨

You can join the #hacktoberfest channel on our Slack if you haven't.

Notes

For the next, when updating images, can you please:

  1. remove the old image, then commit it.
  2. add new image, then commit it.

If you don't do this, it results in no changes show in the "Files changed" as you've seen in your PR here. That's because the file name of the image is the same and this behaviour is expected. But we don't get a clear history of the changes made and we want changes to be recorded with commits.

@adiati98 adiati98 merged commit ef7b1b7 into mautic:5.2 Oct 8, 2025
3 checks passed
@beneyalraj
Copy link
Contributor Author

Sure @adiati98

noted! will make changes accordingly, with proper commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update images in docs/configuration/shortener.rst in branch 5.2

2 participants