Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable timesync and pass on timestamp #661

Closed
mhkabir opened this issue Feb 24, 2017 · 6 comments
Closed

Add option to disable timesync and pass on timestamp #661

mhkabir opened this issue Feb 24, 2017 · 6 comments

Comments

@mhkabir
Copy link
Member

mhkabir commented Feb 24, 2017

For many situations where autopilot stack is running on same board (e.g Snapdragon Flight, Raspberry Pi with Navio), the time-stamp of MAVLink messages does not need to be synchronised, since the time bases are the same.

@vooon What'd be the best way to implement (with a configurable parameter), this "passthrough" mode for timesync? We just want to copy the timestamp from the mavlink messages with proper units.

FYI @rkintada @Seanmatthews

@vooon
Copy link
Member

vooon commented Feb 24, 2017

Blacklist sys_time.

@mhkabir
Copy link
Member Author

mhkabir commented Feb 24, 2017 via email

@mhkabir
Copy link
Member Author

mhkabir commented Mar 7, 2017

I pushed a preliminary changeset here : https://github.com/mavlink/mavros/tree/uasys-upstreaming

@vooon
Copy link
Member

vooon commented Mar 9, 2017

I think keeping it as PR little better.
Now i has limited debugging, because 16.10 not supported by Kinetic, so for releasing i use ROS Docker, which is not so handy when you need to debug something.

@vooon
Copy link
Member

vooon commented Mar 19, 2017

@mhkabir i merged to upstream, but w/o much testing. Can you test?

@vooon vooon added this to the Version 0.19 milestone Mar 19, 2017
JohnPeterson added a commit to JohnPeterson/mavros that referenced this issue Mar 20, 2017
This skips time sync when we are in simulation. keep an eye on issue mavlink#661
on mavlink/mavros because that is where they are working on adding
a fix for this issue.
@TSC21
Copy link
Member

TSC21 commented Apr 4, 2017

@mhkabir is this working ok to you now?

@mhkabir mhkabir closed this as completed May 4, 2017
JohnPeterson added a commit to JohnPeterson/mavros that referenced this issue Nov 6, 2017
This skips time sync when we are in simulation. keep an eye on issue mavlink#661
on mavlink/mavros because that is where they are working on adding
a fix for this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants