Skip to content

Commit 2f3b92f

Browse files
committed
function references can leak
1 parent cce5c8e commit 2f3b92f

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

dist/script.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
!function(win, doc, timeout) {
1818
var script = doc.getElementsByTagName("script")[0],
19-
list = {}, ids = {}, delay = {}, re = /^i|c/, loaded = 0, fns = [],
19+
list = {}, ids = {}, delay = {}, re = /^i|c/, loaded = 0, fns = [], ol,
2020
scripts = {}, s = 'string', f = false, i, testEl = doc.createElement('a'),
2121
push = 'push', domContentLoaded = 'DOMContentLoaded', readyState = 'readyState',
2222
addEventListener = 'addEventListener', onreadystatechange = 'onreadystatechange',
@@ -109,20 +109,20 @@
109109
}, 50);
110110
}
111111

112-
testEl.doScroll && doc.attachEvent(onreadystatechange, function ol() {
112+
testEl.doScroll && doc.attachEvent(onreadystatechange, (ol = function ol() {
113113
/^c/.test(doc[readyState]) &&
114114
(loaded = 1) &&
115115
!doc.detachEvent(onreadystatechange, ol) &&
116116
each(fns, function (f) {
117117
f();
118118
});
119-
});
119+
}));
120120

121121
var domReady = testEl.doScroll ?
122122
function (fn) {
123123
self != top ?
124124
!loaded ?
125-
fns.push(fn) :
125+
fns[push](fn) :
126126
fn() :
127127
!function () {
128128
try {

dist/script.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/script.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
!function(win, doc, timeout) {
1010
var script = doc.getElementsByTagName("script")[0],
11-
list = {}, ids = {}, delay = {}, re = /^i|c/, loaded = 0, fns = [],
11+
list = {}, ids = {}, delay = {}, re = /^i|c/, loaded = 0, fns = [], ol,
1212
scripts = {}, s = 'string', f = false, i, testEl = doc.createElement('a'),
1313
push = 'push', domContentLoaded = 'DOMContentLoaded', readyState = 'readyState',
1414
addEventListener = 'addEventListener', onreadystatechange = 'onreadystatechange',
@@ -101,20 +101,20 @@
101101
}, 50);
102102
}
103103

104-
testEl.doScroll && doc.attachEvent(onreadystatechange, function ol() {
104+
testEl.doScroll && doc.attachEvent(onreadystatechange, (ol = function ol() {
105105
/^c/.test(doc[readyState]) &&
106106
(loaded = 1) &&
107107
!doc.detachEvent(onreadystatechange, ol) &&
108108
each(fns, function (f) {
109109
f();
110110
});
111-
});
111+
}));
112112

113113
var domReady = testEl.doScroll ?
114114
function (fn) {
115115
self != top ?
116116
!loaded ?
117-
fns.push(fn) :
117+
fns[push](fn) :
118118
fn() :
119119
!function () {
120120
try {

0 commit comments

Comments
 (0)