Skip to content

chore(typescript): always use explicit override #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
Merged

chore(typescript): always use explicit override #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
876ee1a
refactor: no implicit override in TypeScript code
tbouffard Sep 23, 2025
d757f1a
order props in tsconfig [skip ci]
tbouffard Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions projects/_shared/src/custom-shapes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class CustomRectangleShape extends RectangleShape {
this.isRounded = true; // force rounded shape
}

paintBackground(
override paintBackground(
c: AbstractCanvas2D,
x: number,
y: number,
Expand All @@ -24,7 +24,7 @@ class CustomRectangleShape extends RectangleShape {
super.paintBackground(c, x, y, w, h);
}

paintVertexShape(
override paintVertexShape(
c: AbstractCanvas2D,
x: number,
y: number,
Expand All @@ -41,7 +41,7 @@ class CustomEllipseShape extends EllipseShape {
super(bounds, fill, stroke, 5);
}

paintVertexShape(
override paintVertexShape(
c: AbstractCanvas2D,
x: number,
y: number,
Expand Down
1 change: 1 addition & 0 deletions projects/_shared/src/generate-graph.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ class CustomGraph extends BaseGraph {
// Register builtin styles
PerimeterRegistry.add('ellipsePerimeter', Perimeter.EllipsePerimeter);
PerimeterRegistry.add('rectanglePerimeter', Perimeter.RectanglePerimeter); // declared in the default vertex style, so must be registered to be used

EdgeStyleRegistry.add('orthogonalEdgeStyle', EdgeStyle.OrthConnector, {handlerKind: 'segment', isOrthogonal: true});

const arrowFunction = EdgeMarker.createArrow(2);
Expand Down
3 changes: 2 additions & 1 deletion projects/_shared/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"declaration": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true
"noImplicitOverride": true,
"noImplicitReturns": true,
},
"include": ["src"]
}