-
Notifications
You must be signed in to change notification settings - Fork 2
Wakaama #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wakaama's files are added to compilation. There was need to change name of wakaama/list.c to something else because of conflict with list.c from FreeRTOS sources. Problem rised in first place because current makefile flaten directory tree in build directory, so every compiled *.c file in our project has to have unique name.
This patch implements lwm2m_malloc, lwm2m_free, lwm2m_strdup, lwm2m_gettime and lwm2m_printf functions. These functions are platform specific and have to be implemented to use wakama. Still left to implement are lwm2m_connect_server, lwm2m_close_connection, lwm2m_buffer_send and lwm2m_session_is_equal.
New heap size is 102400 bytes (100kB).
Chimstaz
approved these changes
Nov 2, 2018
Collaborator
Chimstaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this look good
Co-Authored-By: maxiwoj <maxwojczuk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know the PR is long, but please do check the files under Src dir