Support static_ip_score #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oschwald
reviewed
Dec 10, 2019
| * available from GeoIP2 Precision Insights. | ||
| */ | ||
| @JsonProperty("static_ip_score") | ||
| public Double getStaticIPScore() { |
Member
There was a problem hiding this comment.
This should be getStaticIpScore to be consistent with our naming for our Java libraries.
horgh
requested changes
Dec 11, 2019
| } | ||
|
|
||
| @JsonProperty("user_count") | ||
| public Integer getUserCount() { |
Contributor
There was a problem hiding this comment.
Should we have a comment documenting this?
| the Enterprise database and the `country()` method can be called on City | ||
| databases. Request by Gergely Boromissza. GitHub #132. | ||
| * New `getStaticIpScore()` and `getUserCount()` methods were added to | ||
| `com.maxmind.geoip2.record.Traits` for use with GeoIP2 Precision Insights. |
Contributor
There was a problem hiding this comment.
Should we say anything about what they are? I think in the other libraries we've been doing that.
added 2 commits
December 11, 2019 21:00
horgh
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.