Skip to content

Conversation

@koron
Copy link

@koron koron commented Mar 25, 2015

I borrow ByteBufferCleaner from sparkey-java.
And it is originated by Lucene

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.69%) to 90.16% when pulling e9cc6fc on koron:unmap-explicitly into fc615de on maxmind:master.

@oschwald
Copy link
Member

Thanks! I'll have to take a closer look at the licensing and also consider whether we want to use unsupported/undocumented calls. This implementation looks reasonable though and may reduce the pain points for users where mapping locks the file.

@oschwald
Copy link
Member

We decided against including this for the above reasons.

@oschwald oschwald closed this Sep 27, 2017
@koron koron deleted the unmap-explicitly branch September 28, 2017 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants