Discard the reference to the underlying buffer during close(), and throw… #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…row ClosedDatabaseException on subsequent database access. Currently clients can continue to access the database even after it has been closed. This prevents that, and should also help ensure the underlying database is garbage collected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
ClosedDatabaseExceptionon subsequent database access.As discussed briefly in pull request #7, currently clients can continue to access the database even after it has been closed. This prevents that, and should also help ensure the underlying database is garbage collected.
This pull request is against master, and conflicts trivially with pull request #7. (Whichever is merged second will require a slight modification.)