Fix #14: jedi>=0.10 compatibility#15
Merged
parente merged 4 commits intoadtech-labs:masterfrom Mar 4, 2017
Merged
Conversation
ericdill
reviewed
Mar 1, 2017
| path = UserContext(text, position).get_path_until_cursor() | ||
| path, dot, like = completion_parts(path) | ||
| before = text[:len(text) - len(like)] | ||
| interpreter = jedi.Interpreter(text, [self.env]) |
There was a problem hiding this comment.
if jedi is not available in the environment, isn't this going to raise a Type error? Something along the lines of None type has no attribute Interpreter. Perhaps this needs a if jedi is not None somewhere in here?
Contributor
Author
There was a problem hiding this comment.
There's a check further up in the function
There was a problem hiding this comment.
ericdill
approved these changes
Mar 1, 2017
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 85.24% 85.28% +0.03%
==========================================
Files 6 6
Lines 427 428 +1
==========================================
+ Hits 364 365 +1
Misses 63 63Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standing on the shoulders of metakernel giants:
https://github.com/Calysto/metakernel/pull/129/files
(Thanks @blink1073)