General code cleanup part #1#29
Conversation
Move usage of coverage to run_tests
* spylon can already do this * It was broken looking for the python cell magic * It uses a metakernel.IPythonKernel instead of the active IPython kernel
* Show a reasonable error message when input is incomplete according to the interpreter * Only use one executors in the thread pool: we must do one thing at a time anyway
Going to do this separately after the general cleanup This reverts commit c8fa833.
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
- Coverage 85.48% 84.31% -1.18%
==========================================
Files 6 6
Lines 434 408 -26
==========================================
- Hits 371 344 -27
- Misses 63 64 +1 |
|
Whoops. Gotta put codecov back in. |
mariusvniekerk
left a comment
mariusvniekerk
left a comment
There was a problem hiding this comment.
Thanks a lot for this
| %%init_spark | ||
| application_name = "My Fancy App" | ||
| launcher.jars = ["file://some/jar.jar"] | ||
| launcher.master = "local[4]" |
There was a problem hiding this comment.
What in the world is this local[4] syntax?
There was a problem hiding this comment.
Spark syntax for how many cores to use. local[4] says "Please use 4 of my cores for the application master." local[*] says "TAKE ALL MY CORES PLZ!"
There was a problem hiding this comment.
Can you add that as a comment in the code?
ericdill
left a comment
ericdill
left a comment
There was a problem hiding this comment.
LGTM? I know very little about this codebase but nothing is standing out to me
|
Going to merge what I've got, then carry on with documenting the other two modules in another PR. Thanks folks. |
3 participants
Prelude to #28, 26, and #22 which will build atop this but that
I want to keep separate for easier review.