Improve handling of ssh key path in instance_ssh() #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #324 , this PR proposes a tiny change to the handling of the ssh key path within the
instance_ssh()function.The change is literally from this:
to this
The rationale is that if
BMA_SSH_DIRis missing a trailing slash, this will ensure that one is present. IfBMA_SSH_DIRdoes have a trailing slash, then a non-fatal double-slash will be present (i.e./path/to/BMA_SSH_DIR//keyname) and the connection will still work. Either way, the default behaviour of~/.ssh/$keynameremains intact.With the current code, a
BMA_SSH_DIRwithout a trailing slash results in e.g./path/to/BMA_SSH_DIRkeynamewhich will obviously fail.