Support packaging with numeric-only git hash #10

mbdevpl · 2023-03-17T03:36:40Z

No description provided.

mbdevpl · 2023-03-17T03:38:23Z

First PR build failed: GitHub-mbdevpl/version-query/PR-10 [build #1]

mbdevpl · 2023-03-17T05:02:57Z

Tools report for GitHub-mbdevpl/version-query/PR-10 [build #3]:

Pylint: not run ❓
Mypy: not run ❓
Pycodestyle: not run ❓
Pydocstyle: not run ❓

Coverage: 99% 🆗 (click for details)

Name                         Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------------------
setup.py                        11      0      2      0   100%
setup_boilerplate.py           188      0     67      0   100%
test/__init__.py                11      1      2      1    85%   19
test/examples.py                49      2     20      2    94%   27->33, 30-31
test/test_git.py               190      0     32      0   100%
test/test_query.py             160      3     59      1    98%   65, 101-102
test/test_setup.py             238      0     70      0   100%
test/test_version.py           153      0     84      0   100%
test/test_with_git_repo.py      81      0     16      1    99%   37->exit
version_query/__init__.py        5      0      0      0   100%
version_query/__main__.py        3      0      2      0   100%
version_query/_version.py        2      0      0      0   100%
version_query/git_query.py     114      1     52      1    99%   63
version_query/main.py           27      0      6      0   100%
version_query/py_query.py       31      5     17      1    83%   14-17, 41
version_query/query.py          50      0      2      0   100%
version_query/version.py       438      7    234      6    98%   137, 158, 163, 165, 192, 496, 507
------------------------------------------------------------------------
TOTAL                         1751     19    665     13    99%

mbdevpl · 2023-03-17T05:04:29Z

PR build fixed: GitHub-mbdevpl/version-query/PR-10 [build #3]

codecov · 2023-03-17T05:05:18Z

Codecov Report

Merging #10 (2ac02da) into main (590d003) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files          17       17           
  Lines        1751     1751           
  Branches      331      358   +27     
=======================================
  Hits         1729     1729           
  Misses         12       12           
  Partials       10       10

Impacted Files	Coverage Δ
setup.py	`100.00% <ø> (ø)`
version_query/main.py	`100.00% <ø> (ø)`
test/test_git.py	`100.00% <100.00%> (ø)`
version_query/git_query.py	`98.24% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mbdevpl · 2023-03-17T08:15:55Z

Tools report for GitHub-mbdevpl/version-query/PR-10 [build #4]:

Pylint: not run ❓
Mypy: not run ❓
Pycodestyle: not run ❓
Pydocstyle: not run ❓

Coverage: 99% 🆗 (click for details)

Name                         Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------------------
setup.py                        11      0      2      0   100%
setup_boilerplate.py           188      0     67      0   100%
test/__init__.py                11      1      2      1    85%   19
test/examples.py                49      2     20      2    94%   27->33, 30-31
test/test_git.py               190      0     32      0   100%
test/test_query.py             160      3     59      1    98%   65, 101-102
test/test_setup.py             238      0     70      0   100%
test/test_version.py           153      0     84      0   100%
test/test_with_git_repo.py      81      0     16      1    99%   37->exit
version_query/__init__.py        5      0      0      0   100%
version_query/__main__.py        3      0      2      0   100%
version_query/_version.py        2      0      0      0   100%
version_query/git_query.py     114      1     52      1    99%   63
version_query/main.py           27      0      6      0   100%
version_query/py_query.py       31      5     17      1    83%   14-17, 41
version_query/query.py          50      0      2      0   100%
version_query/version.py       438      7    234      6    98%   137, 158, 163, 165, 192, 496, 507
------------------------------------------------------------------------
TOTAL                         1751     19    665     13    99%

mbdevpl · 2023-03-17T08:45:18Z

Tools report for GitHub-mbdevpl/version-query/PR-10 [build #5]:

Pylint: warnings ⚠️ (click for details)

************* Module version_query.git_query
version_query/git_query.py:75:0: R1260: '_latest_git_version_tag' is too complex. The McCabe rating is 12 (too-complex)
************* Module version_query.version
version_query/version.py:242:4: R1260: '_get_pre_release_from_args' is too complex. The McCabe rating is 11 (too-complex)
version_query/version.py:20:4: C0103: Class constant name "Major" doesn't conform to UPPER_CASE naming style (invalid-name)
version_query/version.py:21:4: C0103: Class constant name "Minor" doesn't conform to UPPER_CASE naming style (invalid-name)
version_query/version.py:22:4: C0103: Class constant name "Patch" doesn't conform to UPPER_CASE naming style (invalid-name)
version_query/version.py:23:4: C0103: Class constant name "Release" doesn't conform to UPPER_CASE naming style (invalid-name)
version_query/version.py:24:4: C0103: Class constant name "PrePatch" doesn't conform to UPPER_CASE naming style (invalid-name)
version_query/version.py:25:4: C0103: Class constant name "DevPatch" doesn't conform to UPPER_CASE naming style (invalid-name)
version_query/version.py:26:4: C0103: Class constant name "Local" doesn't conform to UPPER_CASE naming style (invalid-name)
version_query/version.py:30:11: R1729: Use a generator instead 'all(_ is not None if flag else _ is None for (_, flag) in zip(version_tuple, flags))' (use-a-generator)
version_query/version.py:33:0: R0902: Too many instance attributes (8/7) (too-many-instance-attributes)
version_query/version.py:75:28: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
version_query/version.py:106:15: R1728: Consider using a generator instead 'tuple(_ for _ in match.groups() if _ is not None)' (consider-using-generator)
version_query/version.py:109:22: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
version_query/version.py:111:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
version_query/version.py:148:14: W0212: Access to a protected member _version of a client class (protected-access)
version_query/version.py:201:4: W1113: Keyword argument before variable positional arguments list in the definition of __init__ function (keyword-arg-before-vararg)
version_query/version.py:502:19: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
version_query/version.py:506:19: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module test.test_version
test/test_version.py:134:12: R0204: Redefinition of version.release type from int to tuple (redefined-variable-type)
************* Module test.examples
test/examples.py:28:33: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
test/examples.py:31:40: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)

-----------------------------------
Your code has been rated at 9.87/10

Mypy: problems ⚠️ (click for details)

version_query/version.py:11: error: Skipping analyzing "semver": module is installed, but missing library stubs or py.typed marker  [import]
version_query/version.py:11: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
version_query/version.py:133: error: Argument "pre_release" to "Version" has incompatible type "Optional[Sequence[Tuple[Optional[str], Optional[str], Optional[int]]]]"; expected "Sequence[Tuple[Optional[str], Optional[str], Optional[int]]]"  [arg-type]
version_query/version.py:133: error: Argument "local" to "Version" has incompatible type "Optional[Tuple[Any, ...]]"; expected "Union[str, Tuple[Any, ...]]"  [arg-type]
version_query/version.py:177: error: Argument "pre_release" to "Version" has incompatible type "Optional[Sequence[Tuple[Optional[str], Optional[str], Optional[int]]]]"; expected "Sequence[Tuple[Optional[str], Optional[str], Optional[int]]]"  [arg-type]
version_query/version.py:177: error: Argument "local" to "Version" has incompatible type "Optional[Tuple[str, ...]]"; expected "Union[str, Tuple[Any, ...]]"  [arg-type]
version_query/version.py:195: error: Argument "pre_release" to "Version" has incompatible type "None"; expected "Sequence[Tuple[Optional[str], Optional[str], Optional[int]]]"  [arg-type]
version_query/version.py:204: error: Incompatible default for argument "pre_release" (default has type "None", argument has type "Sequence[Tuple[Optional[str], Optional[str], Optional[int]]]")  [assignment]
version_query/version.py:204: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
version_query/version.py:204: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
version_query/version.py:205: error: Incompatible default for argument "local" (default has type "None", argument has type "Union[str, Tuple[Any, ...]]")  [assignment]
version_query/version.py:205: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
version_query/version.py:205: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
version_query/version.py:251: error: Argument 1 to "append" of "list" has incompatible type "Tuple[Any, ...]"; expected "Tuple[Optional[str], Optional[str], Optional[int]]"  [arg-type]
version_query/version.py:271: error: Argument 1 to "append" of "list" has incompatible type "Tuple[Union[int, str], ...]"; expected "Tuple[Optional[str], Optional[str], Optional[int]]"  [arg-type]
version_query/version.py:548: error: Incompatible return value type (got "Sequence[Any]", expected "Tuple[Any, ...]")  [return-value]
test/test_version.py:8: error: Skipping analyzing "semver": module is installed, but missing library stubs or py.typed marker  [import]
test/test_version.py:27: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
test/test_version.py:35: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
test/test_version.py:79: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
version_query/git_query.py:66: error: Argument "key" to "sorted" has incompatible type "Callable[[Tuple[Optional[Commit], Optional[TagReference], Optional[Version], int]], Optional[Version]]"; expected "Callable[[Tuple[Optional[Commit], Optional[TagReference], Optional[Version], int]], Union[SupportsDunderLT[Any], SupportsDunderGT[Any]]]"  [arg-type]
version_query/git_query.py:66: error: Incompatible return value type (got "Optional[Version]", expected "Union[SupportsDunderLT[Any], SupportsDunderGT[Any]]")  [return-value]
version_query/git_query.py:76: error: Incompatible default for argument "base_commit" (default has type "None", argument has type "Commit")  [assignment]
version_query/git_query.py:76: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
version_query/git_query.py:76: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
version_query/git_query.py:77: error: Incompatible default for argument "skip_commits" (default has type "None", argument has type "Set[Commit]")  [assignment]
version_query/git_query.py:77: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
version_query/git_query.py:77: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
Found 16 errors in 3 files (checked 17 source files)

Flake518: ran 🆗
Pydocstyle: ran 🆗

Coverage: 99% 🆗 (click for details)

Name                         Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------------------
setup.py                        11      0      2      0   100%
setup_boilerplate.py           188      0     75      0   100%
test/__init__.py                11      1      2      1    85%   19
test/examples.py                49      2     20      2    94%   27->33, 30-31
test/test_git.py               190      0     32      0   100%
test/test_query.py             160      3     69      1    98%   65, 101-102
test/test_setup.py             238      0     70      0   100%
test/test_version.py           153      0     84      0   100%
test/test_with_git_repo.py      81      0     18      1    99%   37->exit
version_query/__init__.py        5      0      0      0   100%
version_query/__main__.py        3      0      2      0   100%
version_query/_version.py        2      0      0      0   100%
version_query/git_query.py     114      1     52      1    99%   63
version_query/main.py           27      0      6      0   100%
version_query/py_query.py       31      5     17      1    83%   14-17, 41
version_query/query.py          50      0      2      0   100%
version_query/version.py       438      7    268      6    98%   137, 158, 163, 165, 192, 496, 507
------------------------------------------------------------------------
TOTAL                         1751     19    719     13    99%

mbdevpl self-assigned this Mar 17, 2023

mbdevpl added 4 commits March 17, 2023 13:42

fix: avoid rare commit sha issue discovered in scoville/axistool#34

8460f2a

chore: refresh requirements

af3cee4

chore: update copyright year

0cda4ae

build: require Python 3.9+ and test on 3.11

ce2f2ca

mbdevpl force-pushed the feature/support-packaging-with-numeric-git-hash branch from 6f2d307 to ce2f2ca Compare March 17, 2023 04:43

docs: update readme

0d0658c

test: install package that uses metadata.json

2f1c59a

mbdevpl added 2 commits March 17, 2023 17:33

build(jenkins): use same Python version for codecov and linting

f47bda8

chore: mention why we install jupyter

2ac02da

mbdevpl merged commit 897c4cc into main Mar 17, 2023

mbdevpl deleted the feature/support-packaging-with-numeric-git-hash branch March 17, 2023 09:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support packaging with numeric-only git hash #10

Support packaging with numeric-only git hash #10

Uh oh!

mbdevpl commented Mar 17, 2023

Uh oh!

mbdevpl commented Mar 17, 2023

Uh oh!

mbdevpl commented Mar 17, 2023

Uh oh!

mbdevpl commented Mar 17, 2023

Uh oh!

codecov bot commented Mar 17, 2023 •

edited

Loading

Uh oh!

mbdevpl commented Mar 17, 2023

Uh oh!

mbdevpl commented Mar 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Support packaging with numeric-only git hash #10

Support packaging with numeric-only git hash #10

Uh oh!

Conversation

mbdevpl commented Mar 17, 2023

Uh oh!

mbdevpl commented Mar 17, 2023

Uh oh!

mbdevpl commented Mar 17, 2023

Uh oh!

mbdevpl commented Mar 17, 2023

Uh oh!

codecov bot commented Mar 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mbdevpl commented Mar 17, 2023

Uh oh!

mbdevpl commented Mar 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Mar 17, 2023 •

edited

Loading