Added methods to determine if updates are enabled for a given characteristic handle. #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That seems reasonable. I will look at how I might do this today. |
|
I've been thinking about your recommendation more. The information to resolve the handle is in the GattServer. How would GattCharacteristic access the GattServer? Would the caller need to provide the BLEDevice object upon which to access the GattCharacteristic? |
|
I see the problem. |
jeremybrodt
force-pushed
the
updatesenabled
branch
from
b847772 to
781f48e
Compare
jeremybrodt
force-pushed
the
updatesenabled
branch
from
781f48e to
744e4ef
Compare
|
@rgrover I believe my latest commit is in line with your recommendation. Let me know if see any issues with this. |
rgrover
pushed a commit
that referenced
this pull request
Jul 1, 2015
…cteristic. follow up from #41. @jeremybrodt did a lovely job submitting that pull request, but there had been too many changes in the neighbouring code recently to merge his work directly. I didn't take the trouble of preseving his submission in the history; my apologies--credit for this API goes entirely to him.
rgrover
pushed a commit
that referenced
this pull request
Jul 2, 2015
============= This is a minor release. Enhancements ~~~~~~~~~~~~ * Introduce API GattServer::areUpdatesEnabled() to determine notification status for a characteristic. This is a follow up from #41. @jeremybrodt did a lovely job submitting that pull request, but there had been too many changes in the neighbouring code recently to merge his work directly. I didn't take the trouble of preserving his submission in the history; my apologies--credit for this API goes entirely to him. * Replace DiscoveredCharacteristic::setupOnDataRead() with GattClient::onDataRead(). * Move GATT_MTU_SIZE_DEFAULT into blecommon.h as BLE_GATT_MTU_SIZE_DEFAULT. * Replace uses of the deprecated updateCharacteristicValue() with ble.gattServer().write(). * Change access levels to protected for various members of the standard services. * Update LinkLossService with a recent change to the definition of GattWriteCallbackParams. Involved renaming member charHandle to handle. Bugfixes ~~~~~~~~ * None.
JayBeavers
pushed a commit
to JayBeavers/ble-api
that referenced
this pull request
Mar 19, 2016
Author: Rohit Grover Introduce GattServer API to determine notification status for a characteristic. follow up from ARMmbed/ble#41. @jeremybrodt did a lovely job submitting that pull request, but there had been too many changes in the neighbouring code recently to merge his work directly. I didn't take the trouble of preseving his submission in the history; my apologies--credit for this API goes entirely to him.
jacobrosenthal
pushed a commit
to jacobrosenthal/ble
that referenced
this pull request
Dec 24, 2017
Fix small bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, application behavior may be dependent upon whether updates (notifications/indications) are enabled for a characteristic. Since the CCCDs are being created within the adaptation layer, the application does not know the handle of the CCCD attribute for a given characteristic. This allows the application to determine the status from the characteristic's value handle.