fix: /response-headers does not need escaping by default #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it turns out that the fix for GHSA-528q-4pgm-wvg2 in 0decfd1 made an unintentionally breaking change, by HTML-escaping the body of the
/response-headersresponse when no explicitContent-Typeis specified in the incoming request. We do not need to escape by default, because the response will be returned as JSON by default.This was uncovered by @alxndrsn in #207, a separate issue with the
/response-headersendpoint.