Skip to content

fix: /ip should not include port number #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

fix: /ip should not include port number #212

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50850a7
fix: `/ip` should not include port number
mccutchen Jun 10, 2025
0bde92b
fix fix (needs test)
mccutchen Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion httpbin/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"math/rand"
"mime"
"mime/multipart"
"net"
"net/http"
"net/url"
"regexp"
Expand Down Expand Up @@ -64,7 +65,12 @@ func getClientIP(r *http.Request) string {
}

// Finally, fall back on the actual remote addr from the request.
return r.RemoteAddr
remoteAddr := r.RemoteAddr
if strings.IndexByte(remoteAddr, ':') > 0 {
ip, _, _ := net.SplitHostPort(remoteAddr)
return ip
}
return remoteAddr
}

func getURL(r *http.Request) *url.URL {
Expand Down
Loading