Skip to content

Rems 303 reinstantiate mongo#50

Merged
smalho01 merged 10 commits intodevfrom
rems-303-reinstantiate-mongo
Feb 9, 2023
Merged

Rems 303 reinstantiate mongo#50
smalho01 merged 10 commits intodevfrom
rems-303-reinstantiate-mongo

Conversation

@kennyEung
Copy link
Copy Markdown
Contributor

Describe your changes

Created two databases named pims and remsadmin. Also added a mongo-init script to seed the database with the aforementioned database and collections.

Issue ticket number and Jira link

JIRA

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@kennyEung kennyEung changed the base branch from main to dev January 28, 2023 00:40
Comment thread mongo-init.js Outdated
Comment thread docker-compose-dev.yml
Comment thread mongo-init.js Outdated
@smalho01
Copy link
Copy Markdown
Collaborator

smalho01 commented Feb 6, 2023

also added to the readme a command for running the docker instance without using the dev environment for those who prefer to just run locally

@smalho01 smalho01 mentioned this pull request Feb 7, 2023
4 tasks
Copy link
Copy Markdown
Contributor

@KeeyanGhoreshi KeeyanGhoreshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works with #51

@smalho01 smalho01 merged commit 60b1286 into dev Feb 9, 2023
@smalho01 smalho01 deleted the rems-303-reinstantiate-mongo branch February 9, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants