Skip to content

Conversation

@ups216
Copy link
Member

@ups216 ups216 commented Apr 28, 2025

This pull request introduces enhancements to the MCP server data model and GitHub enrichment logic, along with updates to the server sorting mechanism in the API. Key changes include adding new fields to the MCP server interfaces, refining the handling of license type values, and implementing sorting by GitHub stars in addition to recommendation status.

Enhancements to MCP server data model:

  • Added new fields (githubLatestCommit, githubForks, licenseType) to the MCPServer interface in client/src/types.ts and server/src/lib/mcpServers.ts to support additional GitHub-related metadata. [1] [2]
  • Expanded the MCPServer interface in server/src/lib/mcpServers.ts to include boolean flags (isOfficialIntegration, isReferenceServer, isCommunityServer) for categorizing servers.

Refinements to GitHub enrichment logic:

  • Updated the license_type field in EnrichedMcpServer and GithubRepoInfo interfaces to use undefined instead of null when no license information is available. [1] [2]
  • Modified the fetchGithubInfo function to return undefined for license_type if no license data exists, removing the fallback to null.
  • Simplified the assignment of license_type in the enrichServerData function by removing the fallback to undefined.

Updates to server sorting in API:

  • Enhanced the sorting logic in the /search_servers endpoint to prioritize servers by GitHub stars in descending order after recommendation status.
  • Updated the log message in the /search_servers endpoint to reflect the revised sorting criteria.
    This pull request introduces enhancements to the MCP server data model and its enrichment process, focusing on GitHub-related metadata and sorting logic. Key changes include adding new properties to the MCP server interfaces, refining how license types are handled, and improving server sorting by GitHub stars.

Enhancements to MCP server data model:

  • Added new properties to McpServer and EnrichedMcpServer interfaces, including githubLatestCommit, githubForks, and licenseType. These fields allow for richer metadata about GitHub repositories to be stored and accessed. (client/src/types.ts: [1] server/src/lib/mcpServers.ts: [2]
  • Updated the licenseType field to use undefined instead of null when no license information is available, ensuring consistency across the codebase. (server/src/lib/githubEnrichment.ts: [1] [2] [3] [4]

Improvements to server sorting:

  • Modified the sorting logic in the /search_servers route to prioritize servers with higher GitHub star counts after recommended servers, enhancing the relevance of search results. (server/src/routes/hub.ts: server/src/routes/hub.tsR190-R197)
  • Updated logging to reflect the new sorting criteria, providing clearer debugging information. (server/src/routes/hub.ts: server/src/routes/hub.tsL234-R235)

@ups216 ups216 self-assigned this Apr 28, 2025
@ups216 ups216 added the enhancement New feature or request label Apr 28, 2025
@ups216 ups216 merged commit a7365b5 into main Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants