Remove Decorator pattern references in Overriding existing classes examples #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdesantis
force-pushed
the
less-conflict-prone-engine-override-example
branch
2 times, most recently
from
f228025 to
9c96c74
Compare
mdesantis
changed the title
mdesantis
force-pushed
the
less-conflict-prone-engine-override-example
branch
from
9c96c74 to
79468d6
Compare
mdesantis
changed the title
mdesantis
changed the title
mdesantis
changed the title
mdesantis
force-pushed
the
less-conflict-prone-engine-override-example
branch
from
79468d6 to
ee1417c
Compare
mdesantis
changed the title
mdesantis
force-pushed
the
less-conflict-prone-engine-override-example
branch
from
ee1417c to
27567d8
Compare
Engines guide in the Overriding Models and Controllers section references the Decorator pattern, which isn't appropriate, since Decorator pattern is not about reopening existing classes, is about adding functionality to existing object instances; something that in Ruby is commonly implemented using Delegators. Moreover, the suggested naming convention for overrides, `app/decorators/**/*_decorator*.rb`, conflicts with a naming convention commonly used for View Model / Presentation Model decorators, adopted by popular gems such as `draper`, as well as by custom implementations.
mdesantis
force-pushed
the
less-conflict-prone-engine-override-example
branch
from
27567d8 to
491525a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Engines guide in the Overriding Models and Controllers section references the Decorator pattern, which isn't really appropriate, since Decorator pattern is not about reopening existing classes, is about adding functionality to existing object instances; something that in Ruby is commonly implemented using Delegators.
Moreover, the suggested naming convention for overrides,
app/decorators/**/*_decorator*.rb, conflicts with a naming convention commonly used for View Model / Presentation Model decorators, adopted by popular gems such asdraper, as well as custom implementations.