Arihant #4
Open
Arihant #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Collaborator
|
Also there is no need of the package |
hareshkh
reviewed
Feb 8, 2017
| android:layout_height="match_parent" | ||
| android:background="#466" | ||
| tools:context="com.sdsmdg.hareshkh.lectureassignment.arihant.Activities.RecyclerViewActivity"> | ||
| <android.support.v7.widget.RecyclerView |
Collaborator
There was a problem hiding this comment.
RecyclerView is an extension of a viewgroup, and can be used as root layout in absence of other views, which is the case here.
hareshkh
reviewed
Feb 8, 2017
| @@ -0,0 +1,46 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <LinearLayout | |||
Collaborator
There was a problem hiding this comment.
It is preferable to use a single Relative Layout instead of nested Linear Layouts
hareshkh
reviewed
Feb 8, 2017
| @Override | ||
| public void onBindViewHolder(RecyclerView.ViewHolder holder, final int position) { | ||
| final MovieModel movieModel = movieModels.get(position); | ||
| ((Item)holder).itemName.setText(movieModel.getName()); |
Collaborator
There was a problem hiding this comment.
OnBindViewholder can have first parameter as the object of your custom viewHolder ie item so holder does not need to cast to “Item” for every object. Refer AndroidHive again.
|
Package names must be in lower case, haresh already told you to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.