Add new connection security fields. #24455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fields are newly added in 112. They are marked optional as this API is not versioned. ([bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1804460))
github-actions
bot
added
Content:Other
|
Preview URLs
(comment last updated: 2023-02-21 21:44:17) |
rebloor
requested changes
Feb 17, 2023
There was a problem hiding this comment.
Thanks @charlesroper Please find some feedback and could you also add a release note.
files/en-us/mozilla/add-ons/webextensions/api/webrequest/securityinfo/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/api/webrequest/securityinfo/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/api/webrequest/securityinfo/index.md
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/api/webrequest/securityinfo/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: rebloor <git@sherpa.co.nz>
rebloor
reviewed
Feb 18, 2023
files/en-us/mozilla/add-ons/webextensions/api/webrequest/securityinfo/index.md
Show resolved
Hide resolved
|
@dennisjackson please let me know if you need help adding a release note. I also noticed that we need to update the browser compatibility data, also let me know if I can help with this. |
dennisjackson
added a commit
to dennisjackson/browser-compat-data
that referenced
this pull request
Feb 20, 2023
|
I opened a PR for the compat data (mdn/browser-compat-data#18956) and added a release note. |
dennisjackson
requested review from
hamishwillee and
rebloor
and removed request for
a team and
hamishwillee
Co-authored-by: rebloor <git@sherpa.co.nz>
dennisjackson
requested review from
hamishwillee and
rebloor
and removed request for
hamishwillee and
rebloor
willdurand
approved these changes
Feb 21, 2023
rebloor
approved these changes
Feb 21, 2023
|
Thanks @dennisjackson |
rebloor
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add description of new fields on SecurityInfo object which have landed in Firefox Nightly 112.
Motivation
Explain the semantics of the new fields.
Additional details
See 1804460 for further details.