-
Notifications
You must be signed in to change notification settings - Fork 22.9k
update cookie block errors #41597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update cookie block errors #41597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PassionPenguin, and thanks for the update! I've got a few comments for you.
files/en-us/web/privacy/guides/storage_access_policy/errors/cookieblockedall/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/privacy/guides/storage_access_policy/errors/cookieblockedall/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/privacy/guides/storage_access_policy/errors/cookieblockedbypermission/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/privacy/guides/storage_access_policy/errors/cookieblockedbypermission/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/privacy/guides/storage_access_policy/errors/cookieblockedforeign/index.md
Outdated
Show resolved
Hide resolved
| - choosing the _Custom_ Content Blocking and unchecking the _Cookies_ checkbox | ||
| - Going to _Preferences > Privacy & Security > Enhanced Tracking Protection_ and either | ||
| - adding an exception with the _Manage Exceptions_… button | ||
| - choosing the _Custom_ Content Blocking and unchecking the _Tracker_ checkbox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - choosing the _Custom_ Content Blocking and unchecking the _Tracker_ checkbox | |
| - choosing the _Custom_ Content Blocking and unchecking the _Tracker_ checkbox. |
Also, under the "Custom" ETP option, there are checkboxes for "Cookies" and "Tracking content", but not "Tracker".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well i have no idea what's the respective new entry for this :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to me like sites that can use storage are specified under the "Manage browsing data" option. I think you should replace the current second bullet here with a description of that option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the manage browsing data option dialog, it's like
which, seems to be the tool to just remove a specific site's data, but it will not block the site from having third party cookies
i have take a rough look at the firefox codebase, but failed to find the exact related code with the UIs. related constants include BEHAVIOR_REJECT_FOREIGN, BEHAVIOR_LIMIT_FOREIGN and STATE_COOKIES_BLOCKED_FOREIGN, so it may be useful for someone who has knowledge on the changes of the API to help identify the correct place?.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, OK. We've got one option listed to help with this. Why don't we just remove the second bullet for now, and then get it merged? The rest of your changes are pretty useful.
I'm mainly saying this because I have no idea who I'd talk to about this, and it would be a shame to hold up your PR on this small detail while we go digging for info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that would be a good point, and I do really appreciate for your help on the improvement of my purposal!
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @chrisdavidmills !
files/en-us/web/privacy/guides/storage_access_policy/errors/cookieblockedbypermission/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/privacy/guides/storage_access_policy/errors/cookieblockedforeign/index.md
Outdated
Show resolved
Hide resolved
It doesn't need to be bulleted now; it is only one instruction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this is looking good now. Let's get it in. Thanks, @PassionPenguin!
several content are outdated since:
Content blocking was redesigned in Firefox version 70 and is now Enhanced Tracking Protection. Please see the Enhanced Tracking Protection in Firefox for desktop article.
and the cookie & site data tab is redesigned as well