feat(specifications): render a list in simplified mode#1504
Merged
Conversation
Contributor
|
207dbc6 was deployed to: https://fred-pr1504.review.mdn.allizom.net/ |
caugner
approved these changes
Apr 22, 2026
Contributor
caugner
left a comment
There was a problem hiding this comment.
LGTM, just one nit.
PS: If we document simplifiedMode somewhere, we could mention this (alternative) strategy.
Comment on lines
+31
to
+34
| return this.simplifiedMode | ||
| ? html`<ul> | ||
| ${links.map((link) => html`<li>${link}</li>`)} | ||
| </ul>` |
Contributor
There was a problem hiding this comment.
nit: Could we make this an if (this.simplifiedMode) { return html…; } block instead? Even though it's obvious, I had to look twice to see which branch is which.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would've taken a whole lot of repetition (or overhead plumbing) to DRY
renderandrenderSimplifiedhere, so I've added a newsimplifiedModeproperty which can be used instead.This also gives us the flexibility to turn
simplifiedModeinto an enum in the future to specify different simplified targets, imagine something like: