Terminology update, removal of unused macros, repo & comments #273
Conversation
A few of my edits didn't save. Here are 3 comment fixes.
updating discourse link while we're at it.
jwhitlock
left a comment
jwhitlock
left a comment
There was a problem hiding this comment.
Changes look good, I mostly have task ordering questions.
| const examplesBaseUrl = "https://github.com/mdn/webextensions-examples/tree/master/"; | ||
| const allExamples = mdn.fetchJSONResource("https://raw.githubusercontent.com/mdn/webextensions-examples/master/examples.json"); | ||
| const examplesBaseUrl = "https://github.com/mdn/browser-extensions-examples/tree/master/"; |
There was a problem hiding this comment.
This will require renaming the repository. GitHub should redirect the link, so you should do this first.
| !((pathComponents[0] === "webextensions") && (pathComponents[1] === "manifest"))) { | ||
| throw "If an argument is given it must point to WebExtensions manifest data."; | ||
| } | ||
| const manifestDataUrl = "https://raw.githubusercontent.com/mdn/browser-compat-data/master/webextensions/manifest-keys.json"; |
There was a problem hiding this comment.
Is renaming this (https://raw.githubusercontent.com/mdn/browser-compat-data/master/webextensions/manifest-keys.json) is on the eventual plan as well?
| @@ -1,34 +0,0 @@ | |||
| <% | |||
There was a problem hiding this comment.
The macro dashboard claims this one is used on 0 English pages and 93 non-english pages (although only 29 are on the results page). Are we OK breaking those pages until translators get a chance to update them?
There was a problem hiding this comment.
Ah, saw your comment in the original PR, "WebExtCompat will cause localized docs to break but not in en-US. I think localizers should be pinged about this." 👍
|
It's been suggested that we should move the "extensions" docs out of the "Mozilla" bit of the tree, to reflect the fact that they are cross-browser. I'd like to resolve this question before merging this PR. I've started a thread at https://discourse.mozilla.org/t/moving-the-webextensions-docs/17868. |
|
There are now merge conflicts here. |
|
It doesn't look like this will happen. Closing. |
4 participants
Changes root slugs, url slugs changed here (should be changed before if this lands).
constant names left untouched. class names left untouched. Comments for macros updated.
removal of 4 unused macros:
New additional change: {{WebExtExamples}} was edited since this will affect us if we rename repo like {{WebExtAllExamples}}.
All other changes are same as #264 - Will has explained his testing in that PR.
+1 to coordination with @jwhitlock and @escattone.
Ready for review @wbamberg.
Thanks!