Fix ASGI event handling for long-lived connections #53
+79
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After body events are consumed for authentication, the middleware's _fake_receive function now delegates to the original receive callable instead of returning None. This allows downstream applications to properly receive lifecycle events like http.disconnect, enabling proper cleanup for SSE connections, streaming responses, and other long-lived HTTP connections. Adds test to verify that _fake_receive correctly delegates to original receive after body events are exhausted.
jimkont
force-pushed
the
fix/support-sse-connections
branch
from
e7c296b to
2cd2356
Compare
ejinotti-mdsol
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After body events are consumed for authentication, the middleware's _fake_receive function now delegates to the original receive callable instead of returning None.
This allows downstream applications to properly receive lifecycle events like http.disconnect, enabling proper cleanup for SSE connections, streaming responses, and other long-lived HTTP connections.
Adds test to verify that _fake_receive correctly delegates to original receive after body events are exhausted.