Add MAuthHttpx custom authentication scheme for HTTPX
#55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds HTTPX authentication support for MAuth by implementing a custom MAuthHttpx authentication scheme. It also removes Python 3.8 support and updates several dependencies.
- Implements
MAuthHttpxclass that extendshttpx.Authfor MAuth request signing - Removes Python 3.8 support and adds Python 3.13 classifier
- Updates Poetry version to 2.2.1 in GitHub workflows
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| mauth_client/httpx_mauth/client.py | Implements the new MAuthHttpx authentication class with sync and async auth flows |
| mauth_client/httpx_mauth/init.py | Exports MAuthHttpx class from the new module |
| tests/httpx_mauth/client_test.py | Adds unit tests for MAuthHttpx with v1, v2, and combined signature versions |
| README.md | Documents HTTPX usage with MAuthHttpx authentication |
| pyproject.toml | Updates version to 1.6.6, drops Python 3.8, adds Python 3.13, and updates dependencies |
| CHANGELOG.md | Documents version 1.6.6 changes |
| .github/workflows/release.yaml | Updates Poetry version and Python version for release workflow |
| .github/workflows/check.yaml | Updates Poetry version and Python version matrix for CI checks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ykitamura-mdsol
force-pushed
the
feature/httpx
branch
3 times, most recently
from
1763981 to
e12a951
Compare
ykitamura-mdsol
force-pushed
the
feature/httpx
branch
from
e12a951 to
e0e2e90
Compare
cmcinnes-mdsol
approved these changes
Nov 21, 2025
Contributor
cmcinnes-mdsol
left a comment
cmcinnes-mdsol
left a comment
There was a problem hiding this comment.
Nice one thanks @ykitamura-mdsol! One small non blocking request
|
|
||
| # MAuth configuration | ||
| APP_UUID = "<MAUTH_APP_UUID>" | ||
| private_key = open("private.key", "r").read() |
Contributor
There was a problem hiding this comment.
I know this is a copy of the requests mauth example but usually we take our secrets directly from env these days so i wonder if it's more fitting to show that in the example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title says all