-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Improve block parsing for alphanumeric component names #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://mdx-git-alphanumeric-names.mdx.now.sh |
|
Does this solve the issue? 🤔 Could a failing/fixed test help? Note there’s two elements: mdx/packages/remark-mdx/block.js Lines 50 to 51 in 4599f97
|
Component names and HTML can be alphanumeric. This updates the block parsing regex to reflect that. Closes #593
4599f97 to
71a58fa
Compare
MDX is overriding the remark HTML handling so that we can handle JSX syntax which is more flexible. It now should solve the issue with my latest changes this morning.
Added a bunch more test cases 💟 |
ChristianMurphy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @johno! 🙇
Component names and HTML can be alphanumeric. This
updates the block parsing regex to reflect that.
Closes #593