Skip to content
This repository was archived by the owner on Mar 5, 2024. It is now read-only.

Conversation

peiranguo
Copy link

ASANA TASK LINK:
https://app.asana.com/0/0/1185504254404318/f

DESIGN DOC LINK:
https://docs.google.com/document/d/1S7qo2jRIeMdmovHZ6R91dytITUi8tfa1QRvKYa7y18U/edit#

DETAILS

Rotate SA keys for CircleCI

CHECK LIST

Sufficient logging?

Refer to When should I log?

  • I, the reviewer, thought about logging in all possible instances
  • I, the coder, added logging in all possible instances

Good to merge if approved?

  • yes, the reviewer should merge if he/she can upon approval

TEST PLAN:
N

  • Best: "New tests covering XYZ cases"
  • Sometimes: "Run dag and manually verify blah", etc.
  • Occasionally: "Best guess is this fixes the issue." <-- at least be honest!

DID I MATERIALLY UPDATE DOCKERFILE(S)?:
(Y/N)
N

ANY KNOWN IMPACT TO 3rd PARTY (CUSTOMERS, VENDORS, PARTNERS, etc.) integrations or SLAs?:
(Y/N)
N

RISK & IMPACT ASSESSMENT:
Minimal

@peiranguo peiranguo requested a review from cbockman as a code owner July 21, 2020 19:43
@peiranguo
Copy link
Author

New key in use:
Screenshot from 2020-07-21 17-00-08

@cbockman cbockman merged commit 4d90f28 into master Jul 21, 2020
@cbockman cbockman deleted the circleci-sa-key-rotation-2020-07-21 branch July 21, 2020 21:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants