Skip to content
This repository was archived by the owner on Jul 10, 2023. It is now read-only.

Conversation

@kasperkristensen
Copy link
Collaborator

@kasperkristensen kasperkristensen commented Apr 4, 2022

What

  • Adds the ability to upload thumbnail on Gift Card creation
  • Changes the /manage page to use FormContextProvider pattern from other domains
  • Adds uploading and editing images on /manage
  • Adds ability to add new denominations to a already existing Gift Card
  • General clean up in the GiftCard domain
  • Implements detect-dirty-state pattern in /manage form.

Also

  • Omits images from create product if no images have been uploaded
  • Moves consolidateImages to utilities folder

@netlify
Copy link

netlify bot commented Apr 4, 2022

Deploy Preview for nostalgic-booth-1cf149 ready!

Name Link
🔨 Latest commit 0bd6532
🔍 Latest deploy log https://app.netlify.com/sites/nostalgic-booth-1cf149/deploys/625410e3b1b96400083f3bf4
😎 Deploy Preview https://deploy-preview-488--nostalgic-booth-1cf149.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 4, 2022

Deploy Preview for elastic-keller-bcaedb ready!

Name Link
🔨 Latest commit 0bd6532
🔍 Latest deploy log https://app.netlify.com/sites/elastic-keller-bcaedb/deploys/625410e387900a0008f7b213
😎 Deploy Preview https://deploy-preview-488--elastic-keller-bcaedb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 4, 2022

Deploy Preview for palmes-staging-admin ready!

Name Link
🔨 Latest commit 0bd6532
🔍 Latest deploy log https://app.netlify.com/sites/palmes-staging-admin/deploys/625410e3e2cf3e000880751d
😎 Deploy Preview https://deploy-preview-488--palmes-staging-admin.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 4, 2022

Deploy Preview for tekla-admin ready!

Name Link
🔨 Latest commit 0bd6532
🔍 Latest deploy log https://app.netlify.com/sites/tekla-admin/deploys/625410e3e12a7b00092189b0
😎 Deploy Preview https://deploy-preview-488--tekla-admin.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kasperkristensen kasperkristensen changed the title fix: gift card domain fix: gift card domain and omit images on create product if no images are present Apr 11, 2022
@kasperkristensen kasperkristensen marked this pull request as ready for review April 11, 2022 11:31
@netlify
Copy link

netlify bot commented Apr 11, 2022

Deploy Preview for preeminent-gingersnap-0af4e1 ready!

Name Link
🔨 Latest commit 0bd6532
🔍 Latest deploy log https://app.netlify.com/sites/preeminent-gingersnap-0af4e1/deploys/625410e3c40c4c0009d3677f
😎 Deploy Preview https://deploy-preview-488--preeminent-gingersnap-0af4e1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Domain: Missing functionality in Gift Card domain Omit images when creating products if not present

4 participants