Skip to content

Removed unreachable code #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2021
Merged

Removed unreachable code #111

merged 3 commits into from
Apr 14, 2021

Conversation

@sanders41
Copy link
Collaborator

@sanders41 sanders41 commented Mar 31, 2021

In both cases where I removed the sys.exit line there is a raise immediately preceding it so it is impossible to reach the sys.exit

curquiza
curquiza reviewed Mar 31, 2021
View reviewed changes
@curquiza curquiza mentioned this pull request Mar 31, 2021
Closed
@curquiza curquiza requested a review from bidoubiwa March 31, 2021 21:57
bidoubiwa
bidoubiwa approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@bidoubiwa
Copy link
Contributor

bidoubiwa commented Apr 2, 2021

bors merge

bors bot added a commit that referenced this pull request Apr 2, 2021
@bors @sanders41
Merge #111
b03b33f 
111: Removed unreachable code r=bidoubiwa a=sanders41

In both cases where I removed the `sys.exit` line there is a `raise` immediately preceding it so it is impossible to reach the `sys.exit`

Co-authored-by: Paul Sanders <psanders1@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 2, 2021

Build failed:

bors bot added a commit that referenced this pull request Apr 2, 2021
@bors
Try #111:
6100081
@bors
Copy link
Contributor

bors bot commented Apr 2, 2021

try

Build failed:

@bidoubiwa
Copy link
Contributor

bidoubiwa commented Apr 2, 2021

bors try

bors bot added a commit that referenced this pull request Apr 2, 2021
@bors
Try #111:
d2f4b38
@bors
Copy link
Contributor

bors bot commented Apr 2, 2021

try

Build failed:

@bidoubiwa
Copy link
Contributor

bidoubiwa commented Apr 14, 2021

bors try

bors bot added a commit that referenced this pull request Apr 14, 2021
@bors
Try #111:
f62d7fb
@bors
Copy link
Contributor

bors bot commented Apr 14, 2021

try

Build succeeded:

bidoubiwa
bidoubiwa approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@bidoubiwa
Copy link
Contributor

bidoubiwa commented Apr 14, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 14, 2021

Build succeeded:

@bors bors bot merged commit e4de678 into meilisearch:main Apr 14, 2021
@sanders41 sanders41 deleted the unreachable branch April 14, 2021 13:01
@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curquiza curquiza curquiza left review comments

+1 more reviewer

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sanders41 @bidoubiwa @curquiza