Fix asc/desc syntax: make it work for MeiliSearch v0.22.0 and later #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@bidoubiwa, docs-scraper does not currenlty work with MeiliSearch v0.22.0 and later, so we should merge it and release it asap :) |
Member
Author
|
I think this is breaking for the user since we enforce the usage of v0.22.0 of MeiliSearch and later |
curquiza
changed the title
curquiza
changed the title
bidoubiwa
approved these changes
Oct 5, 2021
Contributor
bidoubiwa
left a comment
bidoubiwa
left a comment
There was a problem hiding this comment.
My bad for not fixing this during the previous release. LGTM !
Contributor
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 5, 2021
158: Fix asc/desc syntax: make it work for MeiliSearch v0.22.0 and later r=bidoubiwa a=curquiza Related to https://github.com/meilisearch/MeiliSearch/discussions/1766 Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
Member
Author
|
I totally missed it as well, don't worry! :) |
Contributor
|
Timed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/meilisearch/MeiliSearch/discussions/1766