Upgrade scrapy 2.3.0 #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update scrapy to latest version
curquiza
approved these changes
Sep 21, 2020
Member
curquiza
left a comment
curquiza
left a comment
There was a problem hiding this comment.
Thanks @renehernandez for your help!!
nflx
added a commit
to nflx/typesense-docsearch-scraper
that referenced
this pull request
Sep 19, 2022
This is due to scrapy/scrapy#4254 Sollution copied from meilisearch/docs-scraper#67 Thanks @renehernandez!
nflx
added a commit
to nflx/typesense-docsearch-scraper
that referenced
this pull request
Sep 19, 2022
This is due to scrapy/scrapy#4254 Sollution inspired by meilisearch/docs-scraper#67 Thanks @renehernandez!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #64
As part of PR scrapy/scrapy#4254, the public behavior for the
parsemethod was change inSpiderclass and subclasses. Now, the publicparsemethod in the baseSpiderclass returns aNotImplementedErrorwhich is the error we are running against in theDocumentationSpiderimplementation.So after that PR went in
scrapy, the parse logic that theDocumentationSpiderrelies on was moved to the new_parsemethod (see here. To maintain the same behavior in our end as before the scrapy upgrade to 2.3.0, I have added aparsemethod implementation that simply wraps a call to the_parsemethod inCrawlSpider, as follow: