Skip to content

v0.29: Soft deletion #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 29, 2022
Merged

v0.29: Soft deletion #1866

merged 5 commits into from
Sep 29, 2022

Conversation

@guimachiavelli
Copy link
Member

@guimachiavelli guimachiavelli commented Sep 6, 2022

Closes #1852

@guimachiavelli guimachiavelli added this to the v0.29 milestone Sep 6, 2022
curquiza
curquiza reviewed Sep 6, 2022
View reviewed changes
@guimachiavelli guimachiavelli changed the title storage: add information about soft deletion v0.29: Soft deletion Sep 7, 2022
@guimachiavelli guimachiavelli linked an issue Sep 14, 2022 that may be closed by this pull request
v0.29: Soft deletion warning #1852
Closed
2 tasks
maryamsulemani97
maryamsulemani97 reviewed Sep 20, 2022
View reviewed changes
curquiza
curquiza approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤘

irevoire
irevoire reviewed Sep 22, 2022
View reviewed changes
@guimachiavelli guimachiavelli mentioned this pull request Sep 26, 2022
Closed
@guimachiavelli @irevoire
Update learn/advanced/storage.md
a9b3d4e 
Co-authored-by: Tamo <tamo@meilisearch.com>
maryamsulemani97
maryamsulemani97 reviewed Sep 26, 2022
View reviewed changes
maryamsulemani97
maryamsulemani97 approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@maryamsulemani97 maryamsulemani97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@guimachiavelli
Copy link
Member Author

guimachiavelli commented Sep 29, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 29, 2022

Build succeeded:

@bors bors bot merged commit c5549fc into v0.29 Sep 29, 2022
@bors bors bot deleted the v0.29-soft-deletion branch September 29, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curquiza curquiza curquiza approved these changes

+2 more reviewers

@irevoire irevoire irevoire left review comments

@maryamsulemani97 maryamsulemani97 maryamsulemani97 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.29

Development

Successfully merging this pull request may close these issues.

v0.29: Soft deletion warning

5 participants

@guimachiavelli @irevoire @curquiza @maryamsulemani97