fix: broken links in link checker #2981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to see the preview of this PR?Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:fix/NOT-78 Credentials to access the page are in the company's password manager as "Docs deploy preview". |
|
Looks good to mem thanks! One question: does this cover issues related to the |
I tried that locally and any problems with |
guimachiavelli
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #NOT-78
PR: Fix Link Checker for Query Parameters and Anchor Links
Overview
This PR fixes the issue where the link checker incorrectly flags valid links containing query parameters or hash anchors as broken.
Changes
Query Parameters Handling:
?utm_campaign=...) from internal links before validation.Anchor Links Validation:
#heading) are correctly validated against document headings.No Changes to External or Static Asset Links:
Why
Previously, valid links with query parameters or hash fragments were incorrectly reported as broken. This fix improves the accuracy of the link checker.
Testing
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!