Skip to content

Conversation

@curquiza
Copy link
Member

@curquiza curquiza commented Jul 29, 2020

Closes #6

@curquiza curquiza requested a review from bidoubiwa July 29, 2020 09:10
@curquiza curquiza changed the title Npm publish Add CI to publish to npm Jul 29, 2020
@curquiza curquiza force-pushed the npm-publish branch 2 times, most recently from f3b9727 to 17f50a2 Compare July 29, 2020 09:14
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you add - uses: actions/setup-node@v1 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise it does not work

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we tested to remove that few month ago in meilisearch-js, but it does not work to publish to npm

@curquiza curquiza merged commit 21d558c into master Jul 29, 2020
@curquiza curquiza deleted the npm-publish branch July 29, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CI to push to NPM

3 participants