Skip to content

Conversation

@DhavalGojiya
Copy link
Contributor

@DhavalGojiya DhavalGojiya commented Nov 17, 2025

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • Updates the required Python version in the README from 3.8+ to 3.9+.
  • The previous Python3.8 EOL drop PR (#1039) did not update the README. It still displayed 3.8+ support. This PR fixes that.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Summary by CodeRabbit

  • Documentation
    • Updated minimum Python version requirement to 3.9+.
  • Style
    • Formatting tool configuration updated to target Python 3.9.
  • Chores
    • CI/test matrix adjusted to remove Python 3.8 from configured environments.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 17, 2025

Walkthrough

Updated project metadata and documentation to target Python 3.9: README installation note changed to require Python 3.9+, Black config in pyproject.toml set to py39, and tox.ini removed the py38 env from the envlist. No runtime code or control flow changes.

Changes

Cohort / File(s) Summary
Documentation Update
README.md
Changed minimum Python requirement from 3.8+ to 3.9+ in installation notes.
Formatting tool config
pyproject.toml
Updated Black target-version from py38 to py39.
Test/CI matrix
tox.ini
Removed py38 from the envlist, leaving pylint, mypy, py39, py310, py311. Testenv sections unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Potential review focus:

  • Verify tox envlist change aligns with CI runner availability and any automation that referenced py38.
  • Ensure Black configuration update doesn't conflict with any pre-commit or CI lint steps.

Poem

🐰 A rabbit nibbles code at dawn,
Python hops ahead — 3.9 is on.
Tools aligned and docs refreshed,
Small tweaks made, the meadow’s blessed.
A tidy change, then off I’m gone 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main documentation change updating Python version requirement from 3.8+ to 3.9+ in the README, which is the primary objective stated in the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c85a2e and 8bf275f.

📒 Files selected for processing (2)
  • pyproject.toml (1 hunks)
  • tox.ini (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • pyproject.toml
🔇 Additional comments (1)
tox.ini (1)

2-2: Correctly aligns with Python 3.9+ requirement.

Removing py38 from the envlist is the right approach to align with the project's updated minimum Python version. This prevents tox from attempting to test against Python 3.8, which is no longer supported.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fd4fff6 and 8c85a2e.

📒 Files selected for processing (1)
  • README.md (1 hunks)

@Strift Strift added enhancement New feature or request documentation Improvements or additions to documentation and removed enhancement New feature or request labels Nov 17, 2025
@DhavalGojiya
Copy link
Contributor Author

The README.md change is correct, but the verification uncovered two critical inconsistencies:

tox.ini line 2: Remove py38 from envlist—currently reads envlist = pylint, mypy, py38, py39, py310, py311 but should drop py38
pyproject.toml [tool.black]: Update target-version = ['py38'] to target-version = ['py39'] (or ['py39', 'py310', 'py311', 'py312', 'py313']) to align with requires-python declaration

Are these changes needed as well?

Strift
Strift previously approved these changes Nov 17, 2025
@Strift
Copy link
Contributor

Strift commented Nov 17, 2025

If you can do them in this PR, they would be welcome changes.

We can also do it later, I created #1166 to track

@DhavalGojiya
Copy link
Contributor Author

I will do.

@DhavalGojiya DhavalGojiya requested a review from Strift November 17, 2025 12:10
@Strift Strift linked an issue Nov 18, 2025 that may be closed by this pull request
@Strift Strift added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Nov 18, 2025
Copy link
Contributor

@Strift Strift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🙌 thanks for your contribution @DhavalGojiya!

@Strift Strift added this pull request to the merge queue Nov 18, 2025
Merged via the queue into meilisearch:main with commit 87cf84b Nov 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation maintenance Anything related to maintenance (CI, tests, refactoring...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update tox.ini and pyproject.toml to complete Python 3.8 deprecation.

2 participants