Skip to content

added 2 code samples #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 26, 2022
Merged

added 2 code samples #579

merged 7 commits into from
Oct 26, 2022

Conversation

@Leigh-Ola
Copy link
Contributor

@Leigh-Ola Leigh-Ola commented Oct 25, 2022

Pull Request

Related issue

Fixes #568

What does this PR do?

  • It adds two new code-samples to .code-samples.meilisearch.yaml, as requested by the Meilisearch v0.29 release

PR checklist

Please check if your PR fulfills the following requirements:

  • [✔] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
    It fixes issue Add new code-samples requested by the Meilisearch v0.29 release #568
  • [✔] Have you read the contributing guidelines?
    Yes
  • [✔] Have you made sure that the title is accurate and descriptive of the changes?
    Yes

Thank you so much for contributing to Meilisearch!

@Leigh-Ola
Copy link
Contributor Author

Leigh-Ola commented Oct 25, 2022

@brunoocasali awaiting review, thanks 🙏

brunoocasali
brunoocasali reviewed Oct 25, 2022
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alallema I wait for your call on this :)

Thanks a lot @Leigh-Ola

@Leigh-Ola
Copy link
Contributor Author

Leigh-Ola commented Oct 26, 2022

I've implemented all changes (whitespace & quotation). Thanks!

@Leigh-Ola Leigh-Ola closed this Oct 26, 2022
@Leigh-Ola Leigh-Ola reopened this Oct 26, 2022
alallema
alallema approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @Leigh-Ola,
LGTM!

@alallema
Copy link
Contributor

alallema commented Oct 26, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 26, 2022

Build succeeded:

@bors bors bot merged commit ffa63f0 into meilisearch:main Oct 26, 2022
@alallema alallema added documentation Improvements or additions to documentation skip-changelog The PR will not appear in the release changelogs labels Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunoocasali brunoocasali brunoocasali left review comments

+1 more reviewer

@alallema alallema alallema approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add new code-samples requested by the Meilisearch v0.29 release

3 participants

@Leigh-Ola @alallema @brunoocasali