Skip to content

Conversation

@ellnix
Copy link
Contributor

@ellnix ellnix commented Oct 6, 2023

Pull Request

Related issue

Fixes #863

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b35a4ec) 100.00% compared to head (f0c2cfe) 100.00%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #864   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          721       721           
=========================================
  Hits           721       721           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanders41 sanders41 added the skip-changelog The PR will not appear in the release changelogs label Oct 6, 2023
Copy link
Collaborator

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanders41
Copy link
Collaborator

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Oct 6, 2023

@meili-bors meili-bors bot merged commit fa55d4f into meilisearch:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong argument order in facet_search .code-samples

2 participants